Quelle ChangeLog
Sprache: unbekannt
|
|
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [8ca8d55c161d602844f5428fa4b58097424e324e]
Version 25.8.3.2, tag libreoffice-25.8.3.2
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [534774fc97a57d13884227336ab2ed60acc0fbe1]
bump product version to 25.8.3.2
Change-Id: I2f47b1e30d8c9ee58f3af1c5a55f8fe85bf8da6b
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [2e51257dc43169dde24cbf0952a039cca96c5272]
tdf#164070 always install en-US UI localization on windows
if en-US is not available, and the user didn't manually configure the UI
language, adding another language (via means of mar updater for example)
can cause that new language being used instead of the language the user
had installed initially since there's no explicit default/fallback.
Since any language that will be added in future is likely to not use a
latin script/will be quite unfamliliar to the user, having en-US to rely
on as a fallback is a much better experience.
The problem occurs on systems where the selected UI language is not
matching the windows language, so for new installations the user has to
go to options and set the language manually. That in turn then will be
an additional safeguard for further updates, since now there's a
language explicitly configured and thus no reason for LO to "guess" what
to use as default.
Change-Id: I67dd9a9ddd9de3ce79eb9144eab06b6f10134c57
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193422
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
(cherry picked from commit 51ccb1ead1c94e695489b1c494e4bf611d8b4b5c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193426
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit d74ce83da797b695d6005651f27619eec2077f28)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193430
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [5d7c32c486484ebda0ef782b9d4f513e98ab7835]
update credits
Change-Id: Ic382e9bc69385c1eb704341eefb08183cec8d9df
(cherry picked from commit 2be216b83d7e7755a47575b3233fa287603b6fa8)
(cherry picked from commit bed0442907e5d704e9eab81135ea8eade16448fd)
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [61eaebe9d8715fa23d065fbb8b863adb2d2fb751]
Update git submodules
* Update translations from branch 'libreoffice-25-8-3'
to 7da0bbf085f28f0bb8f22602c61d91c174dbc739
- update translations for 25.8.3 rc2
and force-fix errors using pocheck
Change-Id: If22a8d2459b5c47ce71348461ec2a1c9da3727f0
(cherry picked from commit d22ab41bb76904ff6bcbe25ab70ba23bced8f58b)
2025-11-05 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [9f487c5074691a45f29e657afe9fa58d55cbdd34]
tdf#114068 allow to translate media control tooltips in navigator pane
tooltips for play/pause/stop/repeat/mute were explicitly flagged as
non-translatable for some reason. There is a media toolbar that has the
same set of controls and there could be a way to share the strings, but
they only are a handful, so not really worth a big refactoring of the UI
files for that.
Change-Id: Ia0e8e2bd664916392049df5cd537d51eb04005d1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192873
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Jenkins
(cherry picked from commit 74e55a3c756c1f3ce540bf7ab575ca40a334172d)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192912
Reviewed-by: Martin Srebotnjak <miles@filmsi.net>
(cherry picked from commit dae5ca06276383df0799cf2c92df5e2bb8883be2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193457
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-11-05 Caolán McNamara <caolan.mcnamara@collabora.com> [cd8e1a8b6a863bdbd6917880302e3b770de93be8]
tdf#168672 Closing webdav documents is extremly slow
Change-Id: I9b6c1cbd7ca4c1a8bcce589cbfda5604e66520f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193404
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193428
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-05 Caolán McNamara <caolan.mcnamara@collabora.com> [8980b0e5d443f45404b86dbf592ebe2ffb6adc24]
Related: tdf#168672 ; cid#1642989 Wait without held lock
restore the lock at the end of SerfLockStore::stopTicker
SerfLockStore::removeLockImpl calls this, and that is called
by SerfLockStore::refreshLocks in a loop, so if it was unlocked
at the end of the first loop, then its still unlocked on a 2nd
loop.
Probably doesn't matter as there's only a 2nd unlock attempt
if m_aLockInfoMap.empty() which presumably can only happen once.
Change-Id: Iede91b1b4ef9368bcf4e62cb85bf5a0c745e0ba7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/189058
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 3f3aed00458d64bf32f5faa25c88f959430dea3a)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193403
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193427
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-05 Andras Timar <andras.timar@collabora.com> [e5eb1f972f28db0582e11a31387fff05f85d5ba4]
vcl: check mpWindowImpl for nullptr
Change-Id: Ib70e14cd791415f47772b1053200e9bab6925e8d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193372
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
(cherry picked from commit 4c63a86c88d54db5e69dc8502b6eeffa7f1e4417)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193393
Reviewed-by: Andras Timar <andras.timar@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 5946f67e1db31926af92ea3d0d8eeb58978ea782)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193399
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit bcdd61ad20635e8806993aca311a91c3cfdad6c3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193415
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Andreas Heinisch <andreas.heinisch@yahoo.de> [bbd19f18077882d5945063e77f3ae0db3085a934]
tdf#169108 - Create anonymous database range or data
Create anonymous database range or data during the creation of a pivot table. Otherwise, the selection changes to a old autofilter areas and the pivot table cannot be created.
Change-Id: If55b9d1204ab2ce2c3ee9a227bf0dbe1e222dbcb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193096
Tested-by: Jenkins
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
(cherry picked from commit 2a50c7fbb85941a2c50ac01257af36f132b07006)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193137
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 465e7fddb34fe06d9464ee534c79a02dd72707d4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193143
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-11-04 Caolán McNamara <caolan.mcnamara@collabora.com> [c88828e302b811201171df0da50d6876410c89f0]
Resolves: tdf#144343 This isn't used to toggle navigator on/off
but instead contains a SfxBoolItem which specifies if it should
be shown or hidden and ChildWindowExecute takes care of deciding
if that requires Toggling on or off.
Change-Id: I2ad422041bb6f40f5b726111cf5ce35a32c39128
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193339
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 5e32583e755e877fd1eb68049d6f26d54fd939fe)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193360
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Pranam Lashkari <lpranam@collabora.com> [9d308f0acc9780906167b6cec436cf22c99fc2b9]
tdf#167126: resume ScInputHandler even if error not displayed
problem:
regression from 72bbb0dd4a368dab2b1bd99917cd07d23a92a3f0
when data validity dialog was not displayed, error function returned early
this caused issue with cell invalid data cleaning and it was not possible
to enter new data in any new cell
Change-Id: I612ea8b9c651afba1095fc14726e5398484207f5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193186
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 0b9b82f41a1ff4cbbed6a7148b77cbc3b00c9716)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193355
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit d803223e55e5a762a6916e1c03459d931817ba70)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193358
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Pranam Lashkari <lpranam@collabora.com> [9c89b1991e2cccf35a0a53ee5e3580f14e221388]
tdf#168261: resume ScInputHandler even if error not displayed
problem:
regression from 72bbb0dd4a368dab2b1bd99917cd07d23a92a3f0
when data validity dialog was not displayed, error function returned early
this caused issue with cell invalid data cleaning and it was not possible
to enter new data in any new cell
to reproduce:
select data validity as list and also disable error message showing
enter the invalid data in the validity cell
subsequently its not possible to type in any cells
Change-Id: Ia2157ae57ca90dd9365daae7881640a00c3f1216
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193141
Reviewed-by: Pranam Lashkari <lpranam@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 65ca233db9a39fd251ffac46608bb2714949e894)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193356
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit f60a4baee3852184da95c2947c910b485225d5fb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193359
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Mike Kaganski <mike.kaganski@collabora.com> [0dc4cf8c5a8427b249eff0afb8851b9113b023c2]
tdf#165733: fix leap year detection BCE
lcl_isLeapYear used a simple "is divisible" method to check if a given
year is leap. But that didn't take BCE into account: we use historical
numbering system, where before year 0001 was year -0001; and that year
was leap.
Use comphelper::date::getDaysInMonth for that, which is correct, and
also deduplicates the code. Make sure that years beyond sal_Int16 are
considered an error: they are not representable in css::util::Date,
and comphelper::date::getDaysInMonth takes years as sal_Int16.
Change-Id: I34f1ad4d5d03e05a7cf787f9997b04b1d705b583
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193302
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 97bc8766e297c8d5c22b2f6d4bd7b6d7258782fb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193314
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit c96933d95f1eee1018f893dfc08d9b5d52891201)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193327
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Mike Kaganski <mike.kaganski@collabora.com> [0f23205b390085be25377ff82c1452462e8149bb]
tdf#169147: handle errors creating icu::RegexMatcher
Regression after commit 38f731ff67142a423aa6f46dc3e92d094f86ffb1
(tdf#160478: fix Basic LIKE operator, 2024-04-02).
Change-Id: I4fae01e56cb91d54adba54c3787f576f60f8b1f0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193202
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 3ab2560526ba7b745889cf509241ff17d0638cc2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193221
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-11-04 Xisco Fauli <xiscofauli@libreoffice.org> [ea49312254c953f9183c015727a8d8e01aa4bf7f]
tdf#167963: patch upstream fix
See https://github.com/harfbuzz/harfbuzz/issues/5628
Change-Id: I05bffb1d5e291bd2a5f92bb87aa49bd46d9dc6b8
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193182
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 68822e1bfe0ed83766f4166f8162aacc7e392191)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193199
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Caolán McNamara <caolan.mcnamara@collabora.com> [f779d55e8bcefdd9376a94ece6bfef0bda64b213]
Resolves: tdf#165265 don't autoselect a font style
If nothing was originally selected, then don't pick anything and leave
the combobox empty so the search for style feature doesn't add any
not-explicitly selected font styles by default.
Continue to restore a previously selected style, favouring the last
explicitly selected-by-user style.
Change-Id: Iad04d80305029cc3bbe3e8500ced87085645f9f4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193160
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit e419d3927b62cbc90bbfd0f893adb268af38afdf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193171
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
(cherry picked from commit 54aaa6a1e475921573f07d3e5a3a1f22018574bb)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193198
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-04 Đoàn Trần Công Danh <congdanhqx@gmail.com> [73b8736a14391fdf6f1310cc226e289333e0cc14]
Fix memory leak with poppler-25.10.0
https://gerrit.libreoffice.org/c/core/+/192743, which fixes ftbfs with
poppler 25.10.0, unfortunately introduced a memory leak when building
with poppler 25.10.0 or later. `pOwnerPasswordStr' and
`pUserPasswordStr' ownership are supposed to be transfered to
`pDocUnique', but is now orphaned.
This change fix that said memory leak.
Change-Id: I545d461c07f033b41a4276665483b44fa401a3bd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192645
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 89841fc69446a597b24b978344cd3c8d656aae09)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192934
(cherry picked from commit 1d15201503d2d17ddede4aade0ef4666e64f862b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192948
Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-11-03 Caolán McNamara <caolan.mcnamara@collabora.com> [be86af4142151a10a2cd46ff0bff94019c71981d]
tdf#168979 survive broken color percentile scales
Change-Id: I3180d08272fd7355987f63f5379a044d98467cf0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192838
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192845
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192853
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-11-03 Michael Stahl <michael.stahl@collabora.com> [4986c9c9cc556da7c97c3a41157885dcd1fb110a]
libxslt: add patch for CVE-2025-10911
Change-Id: I951aad2bff3911f685f73390e4f42ed29fe49b41
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192444
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
(cherry picked from commit fca876c2c369b26244413fafe506acafb9d3b5bf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192864
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-11-03 Xisco Fauli <xiscofauli@libreoffice.org> [7d271f90984038127550ae70ac0b0deaee5c1255]
tdf#169015: GetOutlinerParaObject might return nullptr
Regression from
commit 43e511e642a2ce7026b30ea5c212940ff3eb522e
Author: Tibor Nagy <tibor.nagy.extern@allotropia.de>
Date: Fri Nov 29 02:10:21 2024 +0100
tdf#88226 sd: fix cutting off the overflow text on the notes print page
Change-Id: I4e25760afe4bd535d1accf8291f9cbb4457625ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192895
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Tested-by: Jenkins
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 9a406c26e8b8d09b99c949192bc731ba6126cef0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192907
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-11-03 Mike Kaganski <mike.kaganski@collabora.com> [25a24b99856a9725567fde096e7e11f0a3539ce4]
tdf#168314: check if xGraphic is empty, not Any
Regression after commit 9d6e1594a298c9d41f3dc64ad80edf4b9868c2e8
(Deduplicate and unify using vcl::GetBitmap, 2024-11-08).
An Any with an empty graphic is not itself empty; such an any caused
the outer check to succeed, and therefore its 'else' branch never
executed, when it ought to.
Change-Id: I97115c7f7dbab4ec54b5e999e4b47ecdc8874e47
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193161
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit a8216f500c223797b13976678924b76c5effec65)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193170
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit da6b70633ac6bf78ce0a68022518396a2c650970)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193184
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2025-11-03 Stephan Bergmann <stephan.bergmann@collabora.com> [1fc462b65dd9656b576de716ceeb223eca4da76f]
Fix presumed | vs. & typos
...introduced in 25e08e4ea0df956f46bd7ef81493fcf5a5c1879c "Resolves: tdf#164920
add scrollbar width to desired size if enabled" and causing
> svx/source/tbxctrls/linectrl.cxx:435:15: error: bitwise or with non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare]
> 435 | if (nBits | WB_VSCROLL)
> | ~~~~~~^~~~~~~~~~~~
> svx/source/tbxctrls/linectrl.cxx:576:15: error: bitwise or with non-zero value always evaluates to true [-Werror,-Wtautological-bitwise-compare]
> 576 | if (nBits | WB_VSCROLL)
> | ~~~~~~^~~~~~~~~~~~
Change-Id: I6f77cd30f3b98abb15afb665b336fba13d46ee01
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192963
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <stephan.bergmann@collabora.com>
(cherry picked from commit ad6e817e38545903f5fbbe11a2dcb033e5affead)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192968
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit 656a79ed1365851e7f8b0f3dacb29321c0264b6b)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/193021
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2025-10-24 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [96d44dad3c06fe2decfacea5d4dccf4b6e9bdfd0]
update credits
Change-Id: Id71076a39bde8f6c01283e207773f80b3acbb6e2
(cherry picked from commit b65b00d904f8ae1c84c9dbdd9e6629080aee858a)
(cherry picked from commit 216c31600970374b12a5f2aaf6d9f91098e1aa4c)
2025-10-22 Caolán McNamara <caolan.mcnamara@collabora.com> [3a08160072f04e172364115161002699078eaacc]
crash in GetPercentile with empty std::vector first arg
/opt/collaboraoffice/program/../program/libsclo.so
(anonymous namespace)::GetPercentile(std::vector<double, std::allocator<double> > const&, double)
sc/source/core/data/colorscale.cxx:624
/opt/collaboraoffice/program/../program/libsclo.so
__gnu_cxx::__normal_iterator<std::unique_ptr<ScColorScaleEntry, o3tl::default_delete<ScColorScaleEntry> > const*, std::vector<std::unique_ptr<ScColorScaleEntry, o3tl::default_delete<ScColorScaleEntry> >, std::allocator<std::unique_ptr<ScColorScaleEntry, o3tl::default_delete<ScColorScaleEntry> > > > >::operator*() const
/opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_iterator.h:1096
/opt/collaboraoffice/program/libscfiltlo.so
ScHTMLExport::WriteCell(sc::ColumnBlockPosition&, short, int, short)
sc/source/filter/html/htmlexp.cxx:923
/opt/collaboraoffice/program/libscfiltlo.so
ScHTMLExport::WriteTables()
sc/source/filter/html/htmlexp.cxx:864
/opt/collaboraoffice/program/libscfiltlo.so
ScHTMLExport::WriteBody()
sc/source/filter/html/htmlexp.cxx:699
/opt/collaboraoffice/program/libscfiltlo.so
ScHTMLExport::Write()
sc/source/filter/html/htmlexp.cxx:313
/opt/collaboraoffice/program/libscfiltlo.so
rtl::OUString::operator=(rtl::OUString const&)
include/rtl/ustring.hxx:586
/opt/collaboraoffice/program/../program/libsclo.so
ErrCode::IgnoreWarning() const
include/comphelper/errcode.hxx:102 (discriminator 1)
/opt/collaboraoffice/program/../program/libsclo.so
rtl::OUString::~OUString()
include/rtl/ustring.hxx:546
/opt/collaboraoffice/program/libmergedlo.so
TransferableHelper::SetObject(void*, unsigned int, com::sun::star::datatransfer::DataFlavor const&)
vcl/source/treelist/transfer.cxx:912 (discriminator 1)
/opt/collaboraoffice/program/../program/libsclo.so
ScTransferObj::GetData(com::sun::star::datatransfer::DataFlavor const&, rtl::OUString const&)
sc/source/ui/app/transobj.cxx:395
ScColorScaleFormat::CalcValue is optimized out, but it has to be
case COLORSCALE_PERCENTILE and getValues() must return an empty vector
Change-Id: I2cf09f19edcb5f30c82eca02e2a0fe95e86c78db
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192823
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192837
Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192844
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192852
Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [68e15c9e131377b92e9a2f166cdcb9e17b44aad6]
bump product version to 25.8.3.1.0+
Change-Id: Ib6fd97222de796d78a8cfc6fc3b2df08aaaa070d
2025-10-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [025d9ad90aee99dfa9f2c99d9e302d0442c1542b]
Branch libreoffice-25-8-3
This is 'libreoffice-25-8-3' - the stable branch for the 25.8.3 release.
Only very safe changes, reviewed by three people are allowed.
If you want to commit more complicated fix for the next 25.8.x release,
please use the 'libreoffice-25-8' branch.
If you want to build something cool, unstable, and risky, use master.
2025-10-22 Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> [a366c2e4aa71a416411ae0c40347ccf6f6ddcdaa]
Update git submodules
* Update translations from branch 'libreoffice-25-8'
to 17df49cf269a1e1917dc5d4347db00a3dd92bab0
- update translations for 25.8.3 rc1
and force-fix errors using pocheck
Change-Id: Ie174d7556325e998d0f7a2e9eb3bfcc9bb93ea6f
2025-10-22 Caolán McNamara <caolan.mcnamara@collabora.com> [b77b59adca898565b88b38a0d5b6b51fcda52f1b]
Resolves: tdf#164920 add scrollbar width to desired size if enabled
Change-Id: Ib6e354d5a4a9076b81e6a26fe78bdd4994024ec1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192755
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
(cherry picked from commit 25e08e4ea0df956f46bd7ef81493fcf5a5c1879c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192810
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Michael Weghorn <m.weghorn@posteo.de> [fa68edb7bbe54c71b7c9507412b1812d2c20b0ff]
a11y: Set mnemonic-widgets in password dialog again
They were dropped in
commit 1791a290a82591d5b0609502e86f07ed69acee5c
Date: Sun Mar 9 13:27:57 2025 +0530
tdf#146947 Add show/reveal toggle to "Set Password" dialog
for no apparent reason, resulting in the Orca
screen reader no longer announcing the text
of the label that describes what the entry
is for.
Example to trigger the dialog:
* start Writer
* "File" -> "Save As"
* check the "Save with Password" checkbox
* hit OK button
Change-Id: Ifbb9c6e69254cf5f9439fcfd5347e845ba09f96a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192820
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
Tested-by: Jenkins
(cherry picked from commit 8ceea0574dbfd84d06ec367c44454e69a1ec5af3)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192828
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-22 Xisco Fauli <xiscofauli@libreoffice.org> [9394454f9e79634d31562e26eb5d1fc868419f3f]
nss: upgrade to 3.117
Downloaded from https://ftp.mozilla.org/pub/security/nss/releases/NSS_3_117_RTM/src/nss-3.117-with-nspr-4.37.tar.gz
Change-Id: If381a7686a6d3db93e45778855ec74ee90be426b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192799
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
(cherry picked from commit b168b52022d59e79dc2c3a9ebdb1b8b968b9c3e2)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192804
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Xisco Fauli <xiscofauli@libreoffice.org> [225263fb51e19032a0aa0fef93778308df648898]
python3: upgrade to 3.11.14
* Add external/python3/setuptools.patch.1 to deal with the space
in Lib/setuptools/_vendor/jaraco/text/Lorem ipsum.txt
Downloaded from https://www.python.org/ftp/python/3.11.14/Python-3.11.14.tar.xz
Change-Id: I0fe4730ee26267e0042fb10b6ad78bbc21ca1ce5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192784
Tested-by: Jenkins
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Xisco Fauli <xiscofauli@libreoffice.org> [1e667fa90e602b89fa3d198897aa85c7cdd01cea]
glm: upgrade to 1.0.2
Downloaded from https://github.com/g-truc/glm/archive/refs/tags/1.0.2.zip
Change-Id: I07b5bc3a63d0dbe196b38f81ef9329ac44c962cd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192781
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit a6080387f85b0018c31060b05e0d223e1541e0f4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192794
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Xisco Fauli <xiscofauli@libreoffice.org> [a96851ee7e3201d719a032d0f85c064eaa7a269e]
poppler: upgrade to 25.10
Downloaded from https://poppler.freedesktop.org/poppler-25.10.0.tar.xz
Change-Id: I05f89f4177312a148a5a15cd1f1b206d1dc01a86
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192743
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit ae83e577501c504f89b434606f05ff1d555729c9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192754
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Xisco Fauli <xiscofauli@libreoffice.org> [c6315f9834a446b9d2ba831ac53781cc7bd5546e]
libgpg-error: upgrade to 1.56
Downloaded from https://gnupg.org/ftp/gcrypt/libgpg-error/libgpg-error-1.56.tar.bz2
Change-Id: I6aeb7723e94cffe6bdcad8cd6af74891210c4d26
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192709
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit 802328a6055106d4bf1ecaba6db1b6cc473b96fd)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192741
Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2025-10-22 Mike Kaganski <mike.kaganski@collabora.com> [e6875a474b394a9d01bd6c05414d8e704f8bb29a]
tdf#168980: don't use shape Z-order to identify shapes
The problem was wrong identification of the shape type, because of
unreliable use of fragile Z-order.
XMLShapeExport::exportShape used xShape's Z-order to get the info
collected for current xShape. Value of Z-order is calculated in
SwXShape::getPropertyValue; it takes into account text boxes of
shapes, which affects the correction in SwTextBoxHelper::getOrdNum.
The correction results in several different objects returning the
same Z-order. And in the specific document, the information that
was collected for a rectangle object, was used for an object of
different type.
Instead of trying to find a smart way to continue using Z-order,
this change uses XShape itself as the key into the map of info,
similar to how XShapes objects are used as keys into ShapesInfos.
Change-Id: Iacbc101623504db4290ad2c283351c4141b2d1b7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192796
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit 0dc93fddcc751a28cfdb936f61bb6f0f4812e4b9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192805
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-21 Khaled Hosny <khaled@aliftype.com> [0704f03eca87491f87381a2fa995f1920bb19151]
tdf#168884: Restore missing transparency in EMF files
Revert unrelated changes from:
commit 1bdf1e2d52a7fae3e1a58ddf15a7657df3d47004
Author: Khaled Hosny <khaled@aliftype.com>
Date: Thu Sep 25 16:33:09 2025 +0300
tdf#168371: Disable ligatures in Impress/Draw with character spacing
I added a new parameter to TextSimplePortionPrimitive2D constructor, and
rTextFillColor that previously was using the default value had now to be
explicitly set, but I should have used COL_TRANSPARENT as that is the
default.
Change-Id: Ie51e8f3f4c68a9539eb3f6cc77fb1e6cf44f673f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192779
Reviewed-by: Khaled Hosny <khaled@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit 1dce54d8fb070d3d4134317612c145a923497bb4)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192788
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-21 Aron Budea <aron.budea@collabora.com> [30ca1deeebbdb3cf69816fe65401d91e36596717]
tdf#168885 oox: save more of empty charts
Otherwise Word will complain.
Affected types: area, bar, bubble, line, stock.
Regression from 3b4c11350a631e27345e87ecfe258d12983cbfbc.
Change-Id: I56d533d9c55bae45240a1b51733ff60f47b1b2e7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192483
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Jenkins
Reviewed-by: Balazs Varga <balazs.varga@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192782
2025-10-21 Miklos Vajna <vmiklos@collabora.com> [7afa99daab032723aabdeea00d6d69cf97928434]
tdf#166319 sw interdependent redlines: fix redo of direct reject for format
Open the bugdoc, select the format part of the insert-then-format
redline in the manage changes dialog, reject, undo, redo: the result is
<ins>AAA</ins>BBB<ins>CCC</ins> instead of one big insert redline.
Similarly, open the other bugdoc with a delete and a format redline in
it, select the format part of the delete-then-format redline in the
manage changes dialog, reject, undo, redo: the result is
<del>AAA</del><format>BBB</format><del>CCC</del> instead of one big
delete redline.
What happens is that the UI action uses
sw::DocumentRedlineManager::RejectRedlineRange(), while the redo uses
sw::DocumentRedlineManager::RejectRedline(), and while the first
supported direct accepts, the later did not.
Fix the problem by:
1) In sw::DocumentRedlineManager::RejectRedlineRange(), create the undo
action with the correct depth & directness for direct rejects
2) In DocumentRedlineManager::RejectRedline(), use use
lcl_RejectOuterFormat() to directly reject a format redline instead
of the usual lcl_AcceptRejectRedl(), which gives us matching behavior
for the UI action & the redo.
Writer's interdependent redlines are now in a reasonable state with
this: actions for the redline under cursor work with ins/del when
possible (looking "through" format); while the manage changes dialog
still allows working on the format redline directly if that's wanted.
Change-Id: Idb90dfbd86ac26ff51da8a34731ea75a48748bdf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192015
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192736
2025-10-21 Miklos Vajna <vmiklos@collabora.com> [fbec8ab124b58779567e14428238136baa1e84d6]
tdf#166319 sw interdependent redlines: fix redo of accept for fmt on ins/del
The bugdoc has <ins>AA<format>BB</format>CC</ins> content, accepting the
BB part "directly (via the sidebar or the manage changes dialog, so you
accept the format, not the underlying insert), then undo, then redo
resulted in <ins>AA</ins><format>BB</format><ins>CC</ins> instead of a
single insert, as expected.
What happens is that the UI action uses
sw::DocumentRedlineManager::AcceptRedlineRange(), while the redo uses
sw::DocumentRedlineManager::AcceptRedline(), and while the first
supported direct accepts, the later did not.
Fix the problem by:
1) Extending SwUndoRedline with a flag to know if the accept/reject to
be performed by redo should be a direct action or not
2) Fixing sw::DocumentRedlineManager::AcceptRedlineRange() to create an
undo action with the correct depth (should be 0, was 1) & save the
direct flag into the undo action
3) In sw::DocumentRedlineManager::AcceptRedline(), use
lcl_AcceptOuterFormat() to accept a format redline directly instead
of the usual lcl_AcceptRejectRedl().
This also fixes the case where you have a format on top of a delete
(instead of an insert).
Change-Id: I78d7ae9eebf8525191a3d9b3a1731d80ad04a75b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191960
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192735
2025-10-21 Miklos Vajna <vmiklos@collabora.com> [772189ecaca99338672d94aeb1f34abb836b7f3e]
tdf#166319 sw interdependent redlines: allow accept/reject for fmt on ins/del
When a format redline is on top of an insert/delete and the uno command
is dispatched to accept/reject the redline under cursor, then we always
interact with the insert/delete, ignoring the format. This is usually
wanted, but now there is no way to interact with the format redline,
even if you would explicitly ask for it.
Notice that the manage changes dialog/sidebar has a separate row for the
format redline and the ins/del redline under it (at the same document
model position), so that gives us a way to select the format redline
explicitly and interact with it.
Implement this by adding a "direct" mode to the edit shell's
AcceptRedline() / RejectRedline().
With this, all of the (insert or delete) then format, (accept or reject)
on it case works in direct mode. Undo also works, redo still needs
fixing.
Change-Id: I7947cd6c7264773d51e63ccd7c45acb001a79d88
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191592
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192734
2025-10-21 Jim Raykowski <raykowj@gmail.com> [55d72acdba8e55ff44da1534d7c9426fc89a6063]
tdf#168929 fix cannot rename objects with CJK languages via Navigator
Change-Id: I11fa5106d63b78a4aacb144ed70ac658607611a1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192704
Tested-by: Jenkins
Reviewed-by: Jim Raykowski <raykowj@gmail.com>
(cherry picked from commit 4f053ee1b55faa9deec3cbf7cb88f265458b20e0)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192739
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [b2947edc956ebd42b994ff08a96ec0fa43a2ec90]
tdf#164677: separator properties in XMLTextColumnsPropertyHandler::equals
When collecting autostyles, each added autostyle is compared with the
already added ones. If all the properties match, new autostyle is not
added, but an existing one is used.
For text columns, the comparison procedure only compared things defined
in XTextColumns interface, and ignored all properties of TextColumns
service - so, styles only differing in those properties were considered
identical, and only the first of them was saved and used for all cases.
This had never been implemented properly; all versions I tested, did the
same, so I doubt it was a regression. But indeed, it was a bug.
Change-Id: I0042067499a904a66ffb10b4f4ce4115d86e6cfb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192639
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192684
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Xisco Fauli <xiscofauli@libreoffice.org> [fbb1d7bcba219685d789c2f4cdf348f8f7f8d696]
related tdf#168511: bundle venv on mac too + Add test
I missed it in
commit dd8c42bf4b6eb5f692bb929547f69a9aedcf6c0c
Author: Xisco Fauli <xiscofauli@libreoffice.org>
Date: Tue Sep 23 10:07:26 2025 +0200
tdf#168511: python3: bundle venv
Change-Id: I180df8df27ece92aaa1feca379d280ff3f1ba2de
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191392
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191398
2025-10-20 Xisco Fauli <xiscofauli@libreoffice.org> [ecda1df6a14e99d5713309b786ff9137dda4767e]
tdf#168511: python3: bundle venv
Change-Id: I5d4b03571099486b981f83b0487cdcbc4dd7a1a7
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191377
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
Tested-by: Jenkins
(cherry picked from commit dd8c42bf4b6eb5f692bb929547f69a9aedcf6c0c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191386
2025-10-20 Justin Luth <jluth@mail.com> [92307cad6a66f4fc891f566b9a40832971b198f4]
tdf#162461 Revert "tdf#129924 docx import: set background color"
This reverts 6.4.1 commit 9476dfe7d1b86b367966e7dedf67e11936c8d9d7
Automatic font-color needs to be exported as automatic,
not some hard-coded value based on some background whatever.
There were lots of fixes related to "highlight" verses "shade"
backgrounds in 7.x, so this hackery would be obsolete anyway.
Change-Id: Ic62fe56c74cffd8c8475befe745e9fb1c227ec1c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192518
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
(cherry picked from commit 74063178d58d30706c68003ee8ad8e6053f8df50)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192695
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [05d1d307e83431f2e1e649ffe3c1f0854b44d13a]
tdf#168673: approx equality threshold no less than 1/2 15th significand
01:26,47 is 0.001000810185185185, which has 16 significant decimals. It
is converted to string as "0.00100081018518519" (15 significands).
The problem was, that when criterion "=0.00100081018518519" is used to
check value 0.001000810185185185, the two numbers differ in five least
significant bits, but rtl_math_approxEqual uses 0x1p-48 to ignore last
four bits only. This is a common problem for numbers close to 1.0E(N).
This change introduces a second threshold, in addition to "only take
into account 48 signigicant bits of mantissa": it calculates the value
of half of 15th decimal unit of the smaller absolute value, and uses
the greater of the two thresholds for the approximate equality.
Change-Id: I2f98ab23c94ca3a2949c3762fbfb6ea563eef94b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/191883
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit d32c664c3df302b7107a70858aa55b11601225cf)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192696
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Miklos Vajna <vmiklos@collabora.com> [e2b2ecad7a0ffdf1e0c34ec70c1987698971cbad]
tdf#165615 sw floattable, no overlap: avoid check against an own follow
Load the bugdoc, the layuot loop control kicks in:
warn:sw.layout:20117:20117:sw/source/core/layout/tabfrm.cxx:1853: LoopControl in SwContentFrame::CalcLowers
and then the content is laid out on 3 pages, while it fits 2 pages in
Word.
What happens is that the document has an inline table, then a floating
table inside that. The inner floating table has tblOverlap set to
'never', and then things go wrong in
SwToContentAnchoredObjectPosition::CalcOverlap().
Fix the problem by checking if the two overlapping fly frames are
actually next to each other in a split fly chain: if we're the precede
of the other fly, then no need to worry about the overlap, that follow
fly will move to the next page anyway.
In theory this would be also interesting for toplevel floating tables,
too -- but in practice CppunitTest_sw_core_layout's testSplitFlyHeader
shows doing this in general would need more work, so just do this for
floating tables which are inside tables.
Change-Id: I4d0f1bd5229f8fbc3bb49af57f88fd6ef911cbfe
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192433
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 72e79a4d75cbbc8615fe9815bbbe9a38780ff856)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192717
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Miklos Vajna <vmiklos@collabora.com> [153a8942c7c9070dbcbb398d90f126ea5ba1a775]
tdf#162730 sw floattable: fix when inside an inline table, with hide mark
Open the bugdoc, it has an outer inline table, then an inner floating
table. The inner table is split, but both parts of it stay on page 1,
leading to overlapping text.
This document's outer table has a single row and a single cell, but the
cell has a <w:hideMark> property. If that's missing, the inner floating
table is split properly.
Fix the problem by ignoring <w:hideMark> in case the cell's only content
is a floating table: in this case setting the row's size type to "fix"
would not be correct anyway.
Regression from commit 2d43c34333076fad092f0cdc0f60f81580acdbee
(Related: tdf#55160 sw floattable, nested DOCX imp: fix inner tbl at
cell start, 2023-09-15).
Change-Id: Ia9759a1c8ebaaa22b547a5ff250fa9dcf7ffbe4a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192512
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 25ab6816990b688bf12004280664fb3810996f1c)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192716
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [80850b7d086e2b0fc7f792130cce951d5d946573]
tdf#167326: Let CalcHeightWithFlys take hidden frame state into account
Table cells use that function to calculate the min cell height. In the
bugdoc, sections inside a cell contained flys, and were hidden. When
the min cell height was calculated, the sections' flys were considered,
despite they were hidden.
Change-Id: Ie5a8fb54a1c9fe21cc5f4d474bd24feabb660330
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192232
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Tested-by: Jenkins
(cherry picked from commit 0ba44065385cbee7c490cf4a97641c19edc79a63)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192713
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [58561ba4dea22e59b7a7fb36170d574cbbcae936]
tdf#168817: don't emit hyperlink markup for Ruby portions
It produced incorrect markup like
<text:a ...><text:ruby ...><text:ruby-base>...</text:a></text:ruby-base><text:ruby-text>...</text:ruby-text></text:ruby>
after commit c50fbdceafdd4b857954f098e38cae03e8bc6064 (tdf#148198: merge
identical hyperlinks of adjacent text ranges on ODF export, 2022-07-18).
Only the inner Text portions need an 'a' element.
Change-Id: Ia5a0b671b5d454b0e9d4dab0295b57249db9f4dd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192249
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192683
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [1aac67235256b90479de733d178bfe6a955a1888]
OUStringLiteral -> OUString
Change-Id: I124ab59b49493a0ca8b052b6f7c0347fae64e765
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192252
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192729
2025-10-20 Jonathan Clark <jonathan@libreoffice.org> [768b67b1b727d93134dba1efd624000b57b653a2]
tdf#166044 sw: Fix cont. footnotes repeating the dest page number
Fixes an issue causing Writer to print the destination page number twice
in footnotes with continuation notices that end in non-Latin text.
This was happening due to subtle mismanagement of the m_bHasFollow flag.
Continuation notices rely on this flag being unset to indicate the field
portion responsible for printing the destination page number, but the
layout algorithm was leaving this flag unset on two different portions.
In Latin-only documents, this bug was hidden by SwLineLayout::CalcLine()
removing the second portion, but this isn't possible when a script
change is involved.
Regression since commit 6c0105307efa15837e9e5287103995312f373b67
(sw: fix stale SwNumberPortion follow flag)
Change-Id: I94c6f7ca75a3cf844d3eff2640d63777ac026717
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192464
Tested-by: Jenkins
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
(cherry picked from commit 23a0a5d5d2d004c85e6230040d4d1475e79f48fc)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192726
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Justin Luth <jluth@mail.com> [482871586febdea7d5ccef815f8ad33ffb40c095]
tdf#157365 sw: apply colorConfig change to SwModule
This fixes a 7.6 regression from
commit 1916d161902bdd52b8cfa5b29153c8f8c39fce52.
Changes made were not immediately applying to new documents,
and perhaps not even to the current document
if the user also looked at SwModule options.
Change-Id: I5fa21cac57ab1bbfc96b9d6d2b7f403b32103e84
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192410
Tested-by: Jenkins
Reviewed-by: Justin Luth <jluth@mail.com>
(cherry picked from commit 2b0bc0ed83cc0ec03ea30570dc7538df22f303b1)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192724
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [aa690147e302325bfbdc44c1fada42e7c59966e5]
tdf#168777: Trailing space must show all decorations, also for ODF
Commit 853e13f9146e83b959bc53152ec103470d55fb4f (tdf#57187: make sure
to put trailing blanks to hole portion in narrow lines, 2023-12-30)
caused a regression, where trailing whitespace lost its decorations.
Commit a877c6ce97f73906c39cf800bc61d7d99847361c (tdf#164487: Introduce
"Show underline" MS Word compatibility option, 2025-02-26) took care
of the Word compatibility case, and introduced a compatibility flag
matching respective flag in Word. It only handled underline, as the
flag name in Word implied.
It turns out, that (1) Word's flag, despite its name, controls all
decorations of trailing writespace (highlignting, strike-out); and
(2) before the original commit, Writer's default was to show all the
decorations as well. Which means, that there is only one case when
the decorations must be omitted: if "Word-compatible trailing blanks"
is enabled, but "Underline Word-compatible trailing blanks" is off.
This change is intended to show trailing space's underline, overline,
strike-out, border, and highlighting correctly.
Change-Id: I68d0aaaa0a7b9610ec817728bd4acad92ef26fe1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192191
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
(cherry picked from commit b36f181bb71c395f9c48c6358bea550ac4767839)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192712
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Jonathan Clark <jonathan@libreoffice.org> [13c6bc02d4c60e6aa35ae2145db431cfe8ae6dba]
tdf#72341 sw: Make inc/dec font size affect all scripts
This change updates the FN_GROW_FONT_SIZE and FN_SHRINK_FONT_SIZE
handlers to scale fonts for all script types, even if the
currently-selected text does not contain a particular type.
This fixes the reported issue that bullets in RTL context are not
resized if a selected list item does not contain CTL characters. This
also fixes the broader issue of inserted text not reflecting earlier
size changes, simply because the script type for that inserted text
wasn't present at the time.
Change-Id: I881f0b90b5c3aecbbf2e40ee2ad6758de9c5bad3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192459
Reviewed-by: Jonathan Clark <jonathan@libreoffice.org>
Tested-by: Jenkins
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192725
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Aron Budea <aron.budea@collabora.com> [2c0f2c55ab43f39e54e8df9164665dd7544d8658]
tdf#168921 sw: don't export user fields with empty names to DOCX
Otherwise Word will complain.
Started from ae5f469d3893de73850ccc369dbf426a4acd8f15.
Change-Id: I223bcea33645e02972bc189eef0b913fc19b3b48
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192583
Reviewed-by: Aron Budea <aron.budea@collabora.com>
Tested-by: Jenkins
(cherry picked from commit bd01fe073f0ef0eae54f6e9a6d4ecce68171d1c9)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192691
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Mike Kaganski <mike.kaganski@collabora.com> [05a0f70a417dbe71ca7b580d6e62c0a7977a0c72]
Some DDE fixes
It seems that some DDE code was virtually never tested in our CI.
That resulted in several unnoticed regressions.
In commit 81b954718f0cdac6873927e869b3e41f863562e7
(loplugin:unnecessaryvirtuals, 2015-06-09), DdeService::MakeTopic
was made non-virtual. That broke its use on Windows, where a derived
class used to override that method (which of course didn't use the
'override' keyvord, hence went unnoticed).
In commit 88e3b846b8a4bd4ce5507d1bc5441ee4167e5326 (remove some dead
bits of DDE, 2016-04-06), DdeService::MakeTopic was finally dropped.
In commit c026b936404bd052fc74283d3cc2e0727ec4edb9 (no need to
allocate SfxDdeDocTopics_Impl separately, 2023-02-28), a check in
SfxApplication::AddDdeTopic was changed from testing if pDocTopics
were initialized to checking if they are empty. The new test made
adding anything to the vector impossible.
This change tried to make it functional again, and adds a (Windows-
only) unit test.
To enable unit test, we need an app name, so that DDE is initialized
properly. Also, ImplDdeService::MakeTopic had a condition to exit
early, when !Application::IsInExecute(). Here we allow to add it, if
unit test is running.
SfxDdeDocTopic_Impl::Put ismodified to store OUString to the Any -
see ScByteSequenceToString::GetString. Without the change, UTF-16
was treated as 8-bit-encoded string.
theDdeInstData in svl/source/svdde/ddecli.cxx is now not a pointer,
bus a function-local static. No need to delete it: it has nothing
that needs to be released. Before, it could get destroyed too early,
preventing DDE from working.
DdeConnection::~DdeConnection could reliably deadlock, when it had
a connection to the server in the same process; processEventsToIdle
is called now to avoid that.
DdeData ctor taking OUString is fixed: xImp->nData is bytes, not
characters.
Change-Id: I9a151eebc65a26b76c9f6134e97cd1f4d2e2b615
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192640
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192690
Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2025-10-20 Miklos Vajna <vmiklos@collabora.com> [7e0713ad8a2b06c9ffd5b5d83b2a28fe1d7012a4]
sc: fix crash in SparklineGroupsContext::onCharacters()
Fixes this assertion failure in a crash report:
/opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1230: constexpr std::vector<_Tp, _Alloc>::reference std::vector<_Tp, _Alloc>::back() [with _Tp = oox::xls::Sparkline; _Alloc = std::allocator<oox::xls::Sparkline>; reference = oox::xls::Sparkline&]: Assertion '!this->empty()' failed.
Backtrace from gdb on the core:
#0 __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51
#1 0x00007f906206e7f1 in __GI_abort () at abort.c:79
#2 0x0000000000af43ee in std::__glibcxx_assert_fail(char const*, int, char const*, char const*) ()
#3 0x00007f904d07ff87 in std::vector<oox::xls::Sparkline, std::allocator<oox::xls::Sparkline> >::back (this=<optimized out>)
at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1228
#4 std::vector<oox::xls::Sparkline, std::allocator<oox::xls::Sparkline> >::back (this=<optimized out>) at /opt/rh/devtoolset-12/root/usr/include/c++/12/bits/stl_vector.h:1228
#5 oox::xls::SparklineGroupsContext::onCharacters(rtl::OUString const&) ()
at sc/source/filter/oox/SparklineFragment.cxx:232
#6 0x00007f905cf0988a in oox::core::ContextHandler2Helper::processCollectedChars() ()
at include/rtl/ustring.hxx:546
#7 0x00007f905cf09a05 in oox::core::ContextHandler2Helper::implEndElement (nElement=3475622, this=0x7f902403e880)
at oox/source/core/contexthandler2.cxx:123
gdb also points out that m_aSparklineGroups is non-empty.
Change-Id: Ib368550f6db0ed7ce4fbe37e056cd416208e7fe9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192424
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
(cherry picked from commit cde426b7dbea32f93607130d13f108330a8b6275)
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/192721
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2025-10-20 Miklos Vajna <vmiklos@collabora.com> [7422b7b60631f0f43fad7781d9f4b0e7fb5a4fb8]
sd: fix crash in SdDrawPagesAccess::remove()
Crashreport signature:
> kit-1853625-1853625 2025-10-05 16:19:13.871457 +0000 [ kitbroker_02b ] SIG Fatal signal received: SIGSEGV code: 1 for address: 0x100
...
> program/libmergedlo.so
> SdrUndoPage::SdrUndoPage(SdrPage&)
> svx/source/svdraw/svdundo.cxx:1308
--> --------------------
--> maximum size reached
--> --------------------
[ Dauer der Verarbeitung: 0.29 Sekunden
(vorverarbeitet)
]
|
2026-03-28
|