/* -*- Mode: C++; tab-width: 4; indent-tabs-mode: nil; c-basic-offset: 4 -*- */ /* * This file is part of the LibreOffice project. * * Based on LLVM/Clang. * * This file is distributed under the University of Illinois Open Source * License. See LICENSE.TXT for details. *
*/
Check for unused classes where the compiler cannot decide (e.g. because of non-trivial or extern ctors) if a variable is unused if only its ctor/dtor are called and nothing else. For example std::vector is a class where the ctor may call further functions, but an unused std::string variable does nothing. On the other hand, std::scoped_lock instances are used for their dtors and so are not unused even if not otherwise accessed.
Classes which are safe to be warned about need to be marked using SAL_WARN_UNUSED (see e.g. OUString). For external classes such as std::vector that cannot be edited there is a manual list below.
*/
UnusedVariableCheck::UnusedVariableCheck( const InstantiationData& data )
: FilteringPlugin( data )
{
}
bool UnusedVariableCheck::VisitVarDecl( const VarDecl* var )
{ if( ignoreLocation( var )) returntrue; if( var->isReferenced() || var->isUsed()) returntrue; if( var->isDefinedOutsideFunctionOrMethod()) returntrue;
auto type = var->getType(); bool check = loplugin::isExtraWarnUnusedType(type);
if (!check)
check = isUnusedSmartPointer(var);
// this chunk of logic generates false+, which is why we don't leave it on /* if (!check && type->isRecordType()) { auto recordDecl = dyn_cast_or_null<CXXRecordDecl>(type->getAs<RecordType>()->getDecl()); if (recordDecl && recordDecl->hasDefinition() && recordDecl->hasTrivialDestructor()) check = true; }
*/ if(check)
{ if( const ParmVarDecl* param = dyn_cast< ParmVarDecl >( var ))
{ if( !param->getDeclName()) returntrue; // unnamed parameter -> unused // If this declaration does not have a body, then the parameter is indeed not used, // so ignore. autoconst parent = param->getParentFunctionOrMethod(); if( const FunctionDecl* func = dyn_cast_or_null< FunctionDecl >( parent)) if( !func->doesThisDeclarationHaveABody() || func->getBody() == nullptr) returntrue; if (autoconst d = dyn_cast_or_null<ObjCMethodDecl>(parent)) { if (!d->hasBody()) { returntrue;
}
}
report( DiagnosticsEngine::Warning, "unused parameter %0",
var->getLocation()) << var->getDeclName();
} else
report( DiagnosticsEngine::Warning, "unused variable %0",
var->getLocation()) << var->getDeclName();
} returntrue;
}
bool UnusedVariableCheck::isUnusedSmartPointer( const VarDecl* var )
{ // if we have a var of smart-pointer type, and that var is both uninitialised and // not referenced, then we can remove it if (!isSmartPointerType(var->getType())) returnfalse;
if (!var->hasInit()) returntrue;
auto cxxConstructExpr = dyn_cast<CXXConstructExpr>(var->getInit()); if (!cxxConstructExpr) returnfalse; return
cxxConstructExpr->getNumArgs() == 0 || cxxConstructExpr->getArg(0)->isDefaultArgument();
}
Die Informationen auf dieser Webseite wurden
nach bestem Wissen sorgfältig zusammengestellt. Es wird jedoch weder Vollständigkeit, noch Richtigkeit,
noch Qualität der bereit gestellten Informationen zugesichert.
Bemerkung:
Die farbliche Syntaxdarstellung und die Messung sind noch experimentell.