/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v.
2.
0. If a copy of the MPL was not distributed with this
* file, You can obtain one at
http://mozilla.org/MPL/2.
0/. */
import importPlugin from "eslint-plugin-import";
import jsxA11y from "eslint-plugin-jsx-a11y";
import react from "eslint-plugin-react";
import globals from "globals";
export default [
{
...jsxA11y.flatConfigs.recommended,
// When adding items to this file please check for effects on sub-directories.
plugins: { import: importPlugin, react, "jsx-a11y": jsxA11y },
settings: {
react: {
version: "
16.
2.
0",
},
},
rules: {
"react/jsx-boolean-value": ["error", "always"],
"react/jsx-key": "error",
"react/jsx-no-bind": [
"error",
{ allowArrowFunctions: true, allowFunctions: true },
],
"react/jsx-no-comment-textnodes": "error",
"react/jsx-no-duplicate-props": "error",
"react/jsx-no-target-blank": "error",
"react/jsx-no-undef": "error",
"react/jsx-pascal-case": "error",
"react/jsx-uses-react": "error",
"react/jsx-uses-vars": "error",
"react/no-access-state-in-setstate": "error",
"react/no-danger": "error",
"react/no-deprecated": "error",
"react/no-did-mount-set-state": "error",
"react/no-did-update-set-state": "error",
"react/no-direct-mutation-state": "error",
"react/no-is-mounted": "error",
"react/no-unknown-property": "error",
"react/require-render-return": "error",
"accessor-pairs": [
"error",
{ setWithoutGet: true, getWithoutSet: false },
],
"array-callback-return": "error",
"block-scoped-var": "error",
// XXX Bug
1326071 - This should be reduced down - probably to
20 or to
// be removed & synced with the mozilla/recommended value.
complexity: ["error",
61],
"consistent-this": ["error", "use-bind"],
eqeqeq: "error",
"func-name-matching": "error",
"guard-for-in": "error",
"max-nested-callbacks": ["error",
4],
"max-params": ["error",
6],
"max-statements": ["error",
50],
"new-cap": ["error", { newIsCap: true, capIsNew: false }],
"no-alert": "error",
"no-div-regex": "error",
"no-duplicate-imports": "error",
"no-eq-null": "error",
"no-extend-native": "error",
"no-extra-label": "error",
"no-implicit-coercion": ["error", { allow: ["!!"] }],
"no-implicit-globals": "error",
"no-loop-func": "error",
"no-multi-assign": "error",
"no-multi-str": "error",
"no-new": "error",
"no-new-func": "error",
"no-octal-escape": "error",
"no-param-reassign": "error",
"no-proto": "error",
"no-prototype-builtins": "error",
"no-return-assign": ["error", "except-parens"],
"no-script-url": "error",
"no-template-curly-in-string": "error",
"no-undef-init": "error",
"no-unmodified-loop-condition": "error",
"no-unused-expressions": "error",
"no-use-before-define": "error",
"no-useless-computed-key": "error",
"no-useless-constructor": "error",
"no-useless-rename": "error",
"no-var": "error",
"no-void": ["error", { allowAsStatement: true }],
"one-var": ["error", "never"],
"operator-assignment": ["error", "always"],
"prefer-destructuring": [
"error",
{
AssignmentExpression: { array: true },
VariableDeclarator: { array: true, object: true },
},
],
"prefer-numeric-literals": "error",
"prefer-promise-reject-errors": "error",
"prefer-rest-params": "error",
"prefer-spread": "error",
"prefer-template": "error",
radix: ["error", "always"],
"sort-vars": "error",
"symbol-description": "error",
"vars-on-top": "error",
yoda: ["error", "never"],
},
},
{
// TODO: Bug
1773467 - Move these to .mjs or figure out a generic way
// to identify these as modules.
files: ["test/schemas/**/*.js", "test/unit/**/*.js", "test/jest/**/*.js"],
languageOptions: {
sourceType: "module",
},
},
{
// These files use fluent-dom to insert content
files: [
"content-src/components/TopSites/**",
"content-src/components/MoreRecommendations/MoreRecommendations.jsx",
"content-src/components/CollapsibleSection/CollapsibleSection.jsx",
"content-src/components/DiscoveryStreamComponents/DSCard/DSCard.jsx",
"content-src/components/DiscoveryStreamComponents/DSEmptyState/DSEmptyState.jsx"
,
"content-src/components/CustomizeMenu/**",
"content-src/components/DiscoveryStreamComponents/TopicSelection/TopicSelection.jsx",
"content-src/components/DiscoveryStreamComponents/InterestPicker/InterestPicker.jsx",
"content-src/components/DiscoveryStreamComponents/ReportContent/ReportContent.jsx",
"content-src/components/WallpaperCategories/WallpaperCategories.jsx",
],
rules: {
"jsx-a11y/anchor-has-content": "off",
"jsx-a11y/heading-has-content": "off",
"jsx-a11y/label-has-associated-control": "off",
"jsx-a11y/no-onchange": "off",
},
},
{
files: [
"bin/**",
"content-src/**",
"loaders/**",
"tools/**",
"test/unit/**",
"test/jest/**",
],
languageOptions: { globals: globals.node },
},
{
// Use a configuration that's appropriate for modules, workers and
// non-production files.
files: ["bin/**", "lib/cache.worker.js", "test/**"],
rules: {
"no-implicit-globals": "off",
},
},
{
files: ["content-src/**", "test/unit/**", "test/jest/**"],
rules: {
// Disallow commonjs in these directories.
"import/no-commonjs": 2,
},
},
{
// vendor.mjs is a webpack entry point and jest-setup.mjs is loaded by Jest;
// their npm imports are resolved by webpack/Jest, not Node's module resolver.
files: ["content-src/vendor.mjs", "test/jest/jest-setup.mjs"],
rules: {
"import/no-unresolved": "off",
},
},
{
// These tests simulate the browser environment.
files: "test/unit/**",
languageOptions: {
globals: {
...globals.browser,
...globals.mocha,
assert: "readonly",
chai: "readonly",
sinon: "readonly",
},
},
},
{
files: "test/jest/**",
languageOptions: {
globals: {
...globals.jest,
},
},
rules: {
"no-shadow": "off",
},
},
{
files: "test/**",
rules: {
"func-name-matching": 0,
"lines-between-class-members": 0,
},
},
];
